[APP][Pro] < group > (3.2.4 - Stable)

Adrian_Rockall · January 7, 2019, 1:01pm

I have just installed the Alpha and come across a problem: go into the app configuration, select my group of curtains then try to make any changes and I get the error message pop up, "Error: group.setSettings is not a function. "

Also I see the group I am editing in the list. Would that cause a problem if I added the group to the group?

Edit: I can’t capture the error message as it disappears when the screen capture occurred.

Adrian_Rockall · January 7, 2019, 1:09pm

Sorry, I’ve just seen the link at the top of the topic about where to post reports so I will add it there as well.

Jamie · January 7, 2019, 1:11pm

All good, to answer your question.

Currently the alpha required a small ‘hack’ to get the settings to work due to an issue with Homey.

https://github.com/athombv/homey-web-api-issues/issues/5

This means that ‘old’ groups you created will not be able to be edited with in the settings. (until athom fix their issue).

The fact the current item shows in the list is a bug - and it would be great if you could create a ticket for it.

Thanks!

Jamie · January 7, 2019, 4:05pm

(V2).00rc12 is out. IF you are still experiencing the problem - please let me know with specific details / steps on what you did to cause the error - so I can reproduce it.

Thanks all!

xAPPO · January 7, 2019, 5:39pm

rc12 seems to have fixed it for me Jamie

DirkdeDraak · January 7, 2019, 6:38pm

With rc12 (just updated) creating a new group is instant on Android. So that issues seems resolved.

Davy · January 7, 2019, 6:56pm

I just created a new group, added 2 ikea gu10 bulbs (connected through Hue), renamed it and moved it in a zone.

Works as expected, but as soon as I reboot it’s still the same errors.
Homey: 2.0.0-rc12
iOs app: 0.18.0 (241)
< Group > version: v2.0.208 beta

robertklep · January 7, 2019, 7:32pm

@jamie this issue sounds like one that also pops up in the Homeykit app: for some reason, device.capabilitiesObj.SOME_CAPABILITY can sometimes be undefined. Still haven’t worked out why/when it happens.

DaneedeKruyff · January 7, 2019, 7:53pm

Yeah, ran into that one on Heimdall too. Found after 2 days of searching (on another users homey without access) it was because of a crashed app for which the device showed that symptoms.

Now I only add a device when device.ready=true, haven’t had the issue since.

github.com

daneedk/com.uc.heimdall/blob/911f23dce9920b4ecb181fc1cc2a6c7a7d50e698/settings/settings.js#L134


    });
},
getDevices() {
    Homey.api('GET', '/devices', null, (err, result) => {
        if (err)
            return Homey.alert('getDevices' + err);
        var array = Object.keys(result).map(function (key) {
            return result[key];
        });
        console.log(array)
        this.devices = array.filter(this.filterArray);
    });
},
async addMonitorFull(device) {
    var i;
    var addDeviceMonitorFull = true;
    for (i = 0; i < this.devicesMonitoredFull.length; i++) {
        if (this.devicesMonitoredFull[i] && this.devicesMonitoredFull[i].id == device.id) {
            addDeviceMonitorFull = false;
        }
    }

github.com

daneedk/com.uc.heimdall/blob/911f23dce9920b4ecb181fc1cc2a6c7a7d50e698/settings/settings.js#L302


},
isLogged(obj) {
    var i;
    for (i = 0; i < this.devicesLogged.length; i++) {
        if (this.devicesLogged[i] && this.devicesLogged[i].id == obj.id) {
            return true;
        }
    }
    return false;
},
filterArray(device) {
    try {
        return device.ready
    } catch(e) {
        return false
    }
},
getZone: function(zoneId) {
    var result = "unknown";
    var zones = this.zones;
    for (let zone in this.zones) {

robertklep · January 7, 2019, 7:58pm

Ah, nice one!

DirkdeDraak · January 7, 2019, 8:02pm

It seems that another issue re-appeared, which I mentioned for rc9 (see post #47 earlier) . @Davy reported it also just now.
An existing group gives the issue “er ging iets fout…”. A newly created group works though. Have not tested it with a reboot.

Jamie · January 8, 2019, 9:02am

Ok from what I can gather when you :

create a new group
rename said group
then restart your homey

You get an error and you can not control the group.

I suspect this actually is actually a race condition with in the homey restart process, which is why it only affecting some groups for some people. @DaneedeKruyff gave me the hint with his device.ready.

When the groups app starts up it grabs all the devices and says to keep an eye out for changes. Now if the group app loads that piece of code prior to the devices app (fibaro/hue/whatever) loading the actual device - it will throw a hissy fit. Which in turn might cause the issue people are experiencing.

Honestly the weirdest part of this bug is the fact it only occurs after renaming a group, I have no idea why that would be the case @robertklep / @DaneedeKruyff ?

If i’m right, then that means two things : ONE : after restarting homey if you wait for all your devices to load - then restart < group > - you wont get the error. TWO: I’m actually a bit stuck as to how to correctly fix this issue short of some sort of lame timer hack.

robertklep · January 8, 2019, 9:09am

Welcome to the wonderful works of lame timer hacks. We’re doing the exact same thing in HomeyKit (when the app starts up, it checks every 30 seconds to see if the number of devices has changed; if it has, it means there are still devices being created and we wait another 30 seconds).

Alternatively, but that might be something that won’t work for your app, we’re watching the device.update event and keep track of which devices are “new” (not seen yet). On v1.5 we used device.create, but on v2 that event may trigger on devices that aren’t “ready” yet.

Is renaming a group the same as renaming any Homey device? If so, I have absolutely no idea why that would cause problems, because it’s something beyond the control of your app (from what I know).

DaneedeKruyff · January 8, 2019, 9:43am

Well, I did go for the lame timer hack (but that’s for adding a new device):

github.com

daneedk/com.uc.heimdall/blob/911f23dce9920b4ecb181fc1cc2a6c7a7d50e698/app.js#L134


async enumerateDevices() {
    // Get the homey object
    const api = await this.getApi();


    api.devices.on('device.create', async(id) => {
        await console.log('New device found!')
        // V1 - const device = await api.devices.getDevice({id: id})


        var device = await api.devices.getDevice({id: id.id})


        // crapy code because a device.create is emitted before a device is fuly added
        // https://github.com/athombv/homey-apps-sdk-issues/issues/23
        if (!device.ready) {
            setTimeout(async function(){
                device = await api.devices.getDevice({id: id.id})
                console.log(device)
                await Homey.app.addDevice(device);
            }, 2000);
        }
        
        //await this.addDevice(device);

I’ve also tried watching the device.update but it seemed the floodgates were opened and decided to not listen in just for finding out when a device became ready after adding so I went the dirty road.
It would be nice if device.ready was emitted but on the other hand I have no idea how many times that would occur.

Davy · January 8, 2019, 9:54am

Manually restarting the < Group > app does makes the groups work after a reboot, good workaround

robertklep · January 8, 2019, 10:40am

Is 2 seconds enough time in your experience?

DaneedeKruyff · January 8, 2019, 10:48am

Yes, for me in my test situation it’s enough.
I wrote this code in anticipation of a useable solution from Athom but not sure we will get on since Emile told us ‘A device’s lifecycle is actually quite complex’ and closed the issue.

robertklep · January 8, 2019, 10:50am

I generalized it a bit so it will check a device once per second:

  async waitForDevice(id) {
    const device = await this.api.devices.getDevice({ id });
    if (device.ready) {
      return device;
    }
    await delay(1000);
    return this.waitForDevice(id);
  }

(theoretically, if a device never becomes ready, this solution isn’t great, but YOLO)

Jamie · January 8, 2019, 4:27pm

I’ve been able to reliably reproduce the bug and more importantly log it. Consequently ive been able to ‘fix it’ - by fix it I mean the group will now be disabled and let you know to restart the app if the group contains any problem devices - For Omega testers.

YOLO fix coming soon, possibly something with doubles the setTimeout value each time it is called.

Jamie · January 10, 2019, 5:28pm

Alpha is now running 2.1.6 - which will now poll the grouped devices and check to ensure that they are .ready.

If a group contains a device(s) which is not ready, has crashed, app disabled etc. The group will continue to work with out said device(s) until When/If they start working again.

This also will fix the race condition people have experienced after renaming/rebooting their homey.

Thanks

Topic		Replies	Views
How to group devices? Questions & Help	7	287	March 10, 2024
Group app dissapeared in Homey app after last update Apps app , homey-pro	24	866	April 17, 2023
Seriously?! No grouping? No virtual devices? Questions & Help	2	205	November 9, 2023
[APP][Pro] Homesh Controller & Homesh Satellite - Connect Homey Pro 2023 to Homey Pro for Led, Speaker, Zwave(satellite) and network resource Apps app , z-wave , homey-pro	285	9567	April 3, 2024
Please let me group and hide devices Ideas & Suggestions	23	2933	August 22, 2023

[APP][Pro] < group > (3.2.4 - Stable)

Related Topics